codeforpdx / codeforpdx/PASS

[Discovery] - Disallow submitting forms that have no input

Open
#629 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discovery enhancement
Dominant language
JavaScript
Stars
38
Forks
23
Avg merge
11m
Merged PRs (30d)
4

Description

Note: This issue is marked for discovery. It is open for discussion and not necessarily decided upon.

Describe the Current Behavior/Feature:

Some of the forms we have allow for submission/confirmation despite having no input or changes being made.

Share Documents modal:

2024-05-09 (4)

Civic Profile Housing form:

2024-05-09 (2)
Rationale:

It doesn't really make sense to allow this. Besides, we already disallow it elsewhere. See:

2024-05-09 (3)
Proposed Changes:

Disable these submission buttons when there is no input.

Possible Drawbacks:

User may want to clear the data they already submitted. Currently that functionality is not in place. Only Basic Information has a clear button but that only clears the current inputs and does not remove the data itself. Housing Information only has a submit button and Financial Information still needs to be created.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Share Documents modal and Civic Profile Housing form, then compare them with the existing form behavior that already disables submission without input. Confirm the intended handling of unchanged or previously submitted data before implementing anything; done means the affected submission buttons remain disabled when there is no new input.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.