codeforpdx / codeforpdx/PASS

[Bug] - New message modal closes when errors instead of staying on modal

Open
#550 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
38
Forks
23
Avg merge
11m
Merged PRs (30d)
4

Description

Bug Description:

Currently, as stated in the title, the new message modal closes out whenever sending a message fails (see Issue #549 when error occurs). While this closing behavior is benefical when sending a successful message, it's not for when the message errors out. Users would probably want to just update the incorrect fields rather than composing a new one.

Screenshots (If applicable):

See reference clip in Issue #549

Possible Solution (optional):

Instead of making the modal close whenever the message fails to send, we could keep the modal open until the user sends a successful message or simply close out of the modal themselves.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the new message modal and its send-error handling, then reproduce the failure described in Issue #549. Done means the modal remains open when sending fails so fields can be corrected, while successful sends still close it and users can close it themselves.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.