[Enhancement] - Vertical scrolling for sign in autocomplete
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 38
- Forks
- 23
- Avg merge
- 11m
- Merged PRs (30d)
- 4
Description
Describe the Current Behavior/Feature:
Was originally described in https://github.com/codeforpdx/PASS/pull/537#pullrequestreview-1743775571 this is mainly for the mobile view. But it looks like the issue is somewhat resolved by allowing the modal to stretch instead (see clip).
https://github.com/codeforpdx/PASS/assets/14917816/9f655e48-715b-4d3f-8277-260102d224d9
Still think it'll be better if we could keep the modal from changing and allow the autocomplete vertical scroll, but that's just a nit. If there's consensus with this, think we could get this implemented.
Rationale:
Quality of life for mobile version of PASS.
Proposed Implementation (if applicable):
Enable vertical scrolling for the element in question. Could keep the viewable height of the autocomplete list to a fixed height.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the behavior described in pull request 537 and reproducing the sign-in autocomplete on mobile. Identify the autocomplete element and verify that its list scrolls vertically within a fixed-height modal without stretching the modal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100