codeforpdx / codeforpdx/PASS

Bug: When logged in, no `h1` element present

Open
#519 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
38
Forks
23
Avg merge
11m
Merged PRs (30d)
4

Description

Bug Description:

When logged in, viewing the page with "Contacts"/"Civic Profile" tabs, there is no h1 for the page.

Reproduction Steps:

1. Log in.
2. On next page when logged in, check the DOM.

Expected Behavior:

There should be an h1 that "describes the content of the page (similar to the document's <title> element)" (from MDN).

Possible Solution (optional):

Add an h1 that describes the content of the page. Don't know if it should be for the entire page (including the tabbed areas of "Contacts"/"Civic Profile") or just the tab themselves. Think it should probably be the whole page.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the logged-in page with the “Contacts” and “Civic Profile” tabs, then inspect the DOM and locate the view responsible for that page. Done means the page has one meaningful h1 describing its content, with the behavior checked in the logged-in state.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.