codefori / codefori/vscode-rpgle

`@rpglint-skip` not working for multi-location errors (e.g. `StringLiteralDupe`, `NoUnreferenced`)

Open
#484 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
57
Forks
35
Avg merge
2d 3h
Merged PRs (30d)
1

Description

### Description

When using the `@rpglint-skip` or `@rpglint-skip-rules` annotation, some error types are not skipped as expected.

This seems to affect rules that report **multiple locations for a single logical issue**, such as:

* `StringLiteralDupe`
* `NoUnreferenced`
* `IncorrectVariableCase`

Even when the annotation is placed correctly, errors are still reported for lines that should be skipped.
---

### Example

```rpg
**free
dcl-s myVar char(10);

// @rpglint-skip
myvar = 'first';

myvar = 'second';

return;
```

#### Expected Behavior

Only one `IncorrectVariableCase` error should be reported (for the second assignment).

The first assignment (`myvar = 'first';`) should be skipped due to the `@rpglint-skip` annotation.

#### Actual Behavior

Two `IncorrectVariableCase` errors are reported:

* One for `myvar = 'first';` (should be skipped)
* One for `myvar = 'second';`

---

### Additional Context

This behavior appears to occur with rules that perform some lookup logic. If all errors for a Literal are skiped it gain works like intended.

---

I'm already working on a solution. The PR should be ready by tomorrow.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.