codeforboston / codeforboston/finda

add pull request "requirements" to documentation

Open
#76 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
57
Forks
98
PR merge metrics
No merged PRs in 30d

Description

I don't really like the word "requirements" (is there a better word?), but there are some things that pull requests should have and we should write those down so we can point people at them.
- tests/lint should pass (`npm test`)
- Javascript changes should have tests
- documentation?
- other things?

It might also be good to a have a pointer to [codeforboston/lgbtq-data](https://github.com/codeforboston/lgbtq-data) for data changes.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.