### Bug: Inconsistent retry exception handling pattern across tasks
@drazisil-codecov is already working on this.
Since Dec 18, 2025.
- Dominant language
- Python
- Stars
- 8
- Forks
- 20
- Avg merge
- 14h 45m
- Merged PRs (30d)
- 6
Description
Bug: Inconsistent retry exception handling pattern across tasks
The LockRetry exception already contains max_retries_exceeded flag set by LockManager, but bundle_analysis_processor.py ignores this flag and calls self._has_exceeded_max_attempts() redundantly. More critically, it then calls safe_retry() which internally checks _has_exceeded_max_attempts again. Meanwhile bundle_analysis_notify.py correctly uses retry.max_retries_exceeded from the exception. While currently these checks are equivalent, the redundant checks create maintenance risk and if LockManager or _has_exceeded_max_attempts logic ever diverges, behavior would become inconsistent across tasks.
Additional Locations (1)
Originally posted by @cursor[bot] in https://github.com/codecov/umbrella/pull/598#discussion_r2631752060
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.