codecov / codecov/codecov-circleci-orb

[BUG] Orb fails with older versions of `curl`

Open
#255 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
26
Forks
47
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
When running this Orb on Ubuntu version 20.04 with an older version of curl, the download succeeds but the Orb fails to execute the last download step.

To Reproduce
Steps to reproduce the behavior:

  1. Use an executor with the docker image of cimg/base:current-20.04

Expected behavior
The download and codecov CLI commands should succeed.

I believe the issue is with the last command that calls an API with curl and prints a version. This command could be removed or replaced with:

  # Get version from the downloaded binary instead of API                                                                                                                   
  v=$(codecov --version 2>&1 | awk -F', version ' '{print $2}' || echo "unknown")    

Regression
The extra curl option of --retry-all-errors was added in version 5 of this Orb.

Screenshots

Image

Product Area
If applicable, the product with the given bug (e.g. coverage, test analytics, browser extension, bundle analysis)

Versions

  • OS: Ubuntu 20.04
  • CI/CD: [CircleCI
  • Uploader: codecov-circleci-orb@v5

Commit and CI link
Provide the commit SHA and CI link. If applicable, provide the entire Codecov output from CI.

Additional context
Add any other context about the problem here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/dist/download.sh at the linked lines 94-96 and reproduce the failure using cimg/base:current-20.04 with an older curl. Compare the final download/version step with the issue's proposed local version lookup. Done means the download and codecov CLI commands succeed on that Ubuntu 20.04 image.

Written by the indexing model from the issue text.

Assessment

Tech stack
bash
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.