codecov / codecov/codecov-action

[BUG] Action continues after download failing with "HTTP error"

Open
#1,896 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
1.7k
Forks
260
Avg merge
1d 7h
Merged PRs (30d)
1

Description

Describe the bug
When the action fails to download https://cli.codecov.io/latest/linux/codecov because of "HTTP error", the rest of the action still proceeds.

To Reproduce
Steps to reproduce the behavior:

  1. Use Github CI action
  2. Have action fail to download CLI because of "HTTP Error"
  3. See action progress despite not having downloaded the CLI required to continue.

Expected behavior
Failed download detected immediately and no attempt to verify the CLI integrity or running the upload-coverage command.

Regression
Not sure.

Screenshots

Run codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7
Run missing_deps=""
All required system dependencies are available.
Run CC_ACTION_VERSION=$(cat ${GITHUB_ACTION_PATH}/src/version)
==> Running Action version 5.5.1
Run git config --global --add safe.directory "/home/runner/work/odc-tools/odc-tools"
Run CC_FORK="false"
==> Fork detected
Run actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
Run if [ "true" == 'true' ] && [ "$CC_FORK" != 'true' ];
Run if [ -z "$CC_BRANCH" ] && [ -z "$CC_TOKEN" ] && [ "$CC_FORK" == 'true' ]
==> Fork detected, setting branch to pjonsson:s3-to-dc-cleanup
Run if [ -z "$CC_SHA" ];
Run ${GITHUB_ACTION_PATH}/dist/codecov.sh
     _____          _
    / ____|        | |
   | |     ___   __| | ___  ___ _____   __
   | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
   | |___| (_) | (_| |  __/ (_| (_) \ V /
    \_____\___/ \__,_|\___|\___\___/ \_/
                            Wrapper-0.2.7
                           
==> Detected linux
 -> Downloading https://cli.codecov.io/latest/linux/codecov
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    15  100    15    0     0     98      0 --:--:-- --:--:-- --:--:--    98
Warning: Problem : HTTP error. Will retry in 2 seconds. 5 retries left.

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    15  100    15    0     0   1925      0 --:--:-- --:--:-- --:--:--  2142
Warning: Problem : HTTP error. Will retry in 2 seconds. 4 retries left.

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    15  100    15    0     0   2540      0 --:--:-- --:--:-- --:--:--  3000
Warning: Problem : HTTP error. Will retry in 2 seconds. 3 retries left.

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    15  100    15    0     0   2097      0 --:--:-- --:--:-- --:--:--  2142
Warning: Problem : HTTP error. Will retry in 2 seconds. 2 retries left.

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    15  100    15    0     0   1330      0 --:--:-- --:--:-- --:--:--  1363
Warning: Problem : HTTP error. Will retry in 2 seconds. 1 retries left.

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    15  100    15    0     0   2630      0 --:--:-- --:--:-- --:--:--  3000
==> Finishing downloading linux:latest
      Version: 
 
gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" imported
gpg: Total number processed: 1
gpg:               imported: 1
==> Verifying GPG signature integrity
 -> Downloading https://cli.codecov.io/latest/linux/codecov.SHA256SUM
 -> Downloading https://cli.codecov.io/latest/linux/codecov.SHA256SUM.sig
 
gpg: no valid OpenPGP data found.
gpg: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
==> Could not verify signature. Please contact Codecov if problem continues
sha256sum: codecov.SHA256SUM: no properly formatted checksum lines found
==> Could not verify SHASUM. Please contact Codecov if problem continues
==> CLI integrity verified

 -> Token length: 0
==> Running upload-coverage
      ./codecov  upload-coverage --git-service github --pr 696 --sha 914f0f6adcda1d70b6c3a07d8a9183433bbae60c --branch pjonsson:s3-to-dc-cleanup --gcov-executable gcov
./codecov: line 1: error: command not found
==> Failed to run upload-coverage

Product Area
Github action?

Versions

  • OS: ubuntu-latest
  • Git Host: GitHub
  • CI/CD: GitHub Actions
  • Uploader: codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7

Commit and CI link
CodeCov output log in "Screenshot" section.

Additional context
None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with dist/codecov.sh, the entry point shown in the log, and trace the download step after the HTTP error. Done means a failed CLI download stops the action before integrity verification and upload-coverage; no test file is mentioned in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.