codecov / codecov/codecov-action
Fail_ci_if_error not actually passing when false
Open
@thomasrockhu-codecov is already working on this.
Since Feb 19, 2025.
Area: Report Upload
bug
codecov/codecov-action
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 260
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 1
Description
Further details and analysis: https://github.com/dandi/dandi-schema/issues/268#issuecomment-2498414015
but here is what we see
see e.g. in https://github.com/dandi/dandi-schema/actions/runs/12004231865/job/33458888905
and oddly the whole workflow marks that matrix run failed although our config has
https://github.com/dandi/dandi-schema/blob/HEAD/.github/workflows/test.yml#L55
fail_ci_if_error: false
so there might be two issues ;-)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.