codebrainz / codebrainz/geany-zencoding

Couple of points I noticed.

Open
#6 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
49
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Couple of points I noticed, wasn't by any means a real review.
1. some of the keybindings clash with standard ones, ++e and t at least, didn't check all the rest.
2. in zen_controller_init_python() the variable resident_pylib is static so its only ever initialised to NULL once, not sure if thats part of your commented intermittent crash on subsequent calls
3. even if the python lib isn't found you fall through to try to initialise anyway, that would probably be a crash.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.