code4romania / code4romania/onghub

[Access Management] Give/Restrict access UI element behavior is not ideal

Open
#368 2 comments 0 reactions 2 assignees Claimed by @anastk-code4 View on GitHub
bug :bug: design future-version seen usability
Dominant language
TypeScript
Stars
6
Forks
5
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Logged in as an AdminONG user, when editing a Employee user, I have the option to give them access to my NGOs apps individually by clicking on a switch button
![image](https://github.com/code4romania/onghub/assets/95479576/9a7f1961-d688-42ba-92b8-95d6b33457b8)

however, to save changes i need to press the button "Save changes". this is contradictory to how switches work in general and how the user would expect it to work (pressing the switch button should make changes, with no additional action from user).

**Steps to reproduce the behavior**
1. Login as AdminONG user
2. Go to Employees page
3. Click on an Employee in the list -> Edit employee
4. See list of apps the employee has access to
5. Click on switch button to change access settings
6. Refresh page
7. see the change was not saved
8. Click on switch button to change access settings
9. click on 'save changes' button
10. refresh page
11. see now the change was saved

**Expected**
1. Switch acts like it is expected: Any change in switch is automatically saved without pressing another button - preferred
or
2. Switches ui elements are replaced with tags (active/inactive) and AdminONG user can change status from (...) menu pressing a button "restrict access"/"give access". Like:
![image](https://github.com/code4romania/onghub/assets/95479576/11a48ff1-89f6-4b06-b885-a331ed634193)

**Screenshots**
![image](https://github.com/code4romania/onghub/assets/95479576/b25372fe-9aaf-4156-b6ff-7c1d3dc2902a)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.