code4craft / code4craft/xsoup

IsNthOfType does not support Nth of matching elements

Open
#14 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
474
Forks
148
PR merge metrics
No merged PRs in 30d

Description

Looking at the code for IsNthOfType it currently only supports finding the Nth element of the elements parent->children.

Consider: div[@id='rr_soc_top'][1]

This xpath is saying find all divs with id='rr_soc_top' and return the first match.

If the html document has, say 2, div[@id='rr_soc_top'] spread throughout the document then IsNthOfType does not work for this scenario.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the Java codebase for IsNthOfType and read how it selects elements relative to a parent’s children. Reproduce the div[@id='rr_soc_top'][1] example with multiple matching divs, then determine how the first matching element should be selected and add coverage for that behavior. Done means nth selection works across matching elements throughout the document.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.