code-yeongyu / code-yeongyu/twitter_video_tools_v2

Error messages are ignored silently

Open
#16 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
12
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Hi, thanks for this library. I just tried it, but unfortunately it's not downloading anything.

To debug, I went to l.177 in `download_video.py` and added a print statement on the error. Without it, the error just gets completely ignored unless it's `429` -> not good

With the print I got:

```
Unable to download JSON metadata: HTTP Error 404: Not Found (caused by ); please report this issue on https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using
yt-dlp -U
```

Turns out that the locked version of yt-dlp is too old and I had to update it.

With the update, it seems to work now :) but the progress bar always shows 100% and 00:00 - not terrible, but kind of defeats the purpose of a progress bar.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in download_video.py around line 177, where the error is currently hidden unless it is HTTP 429, and inspect how the progress bar is updated after the yt-dlp call. Reproduce the failed download with the locked yt-dlp version and a working updated version; done means errors are visible and the progress bar reports meaningful progress and elapsed time.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.