code-forge-io / code-forge-io/remix-hook-form

subscribe function is implicitly `any` with `react-hook-form` >= 7.59.0 installed

Open
#177 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
453
Forks
43
PR merge metrics
No merged PRs in 30d

Description

There was a typo in the `UseFormSubscribe` type of react-hook-form that was fixed in this pr https://github.com/react-hook-form/react-hook-form/issues/12899. Since the built version of `remix-hook-form@7.1.1` exposes those types internally, users with a version of `react-hook-form>=7.59.0` will notice an `any` when trying to access those properties from `useRemixForm`.

I think it may be worth updating the `react-hook-form` peerDependency to at least `7.59.0 `, and possibly consider how to avoid the implicit dependency on the types.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.