code-corps / code-corps/code-corps-ember

Github SignUp/SignIn

Open
#1,373 1 comment 0 reactions 0 assignees View on GitHub
needs estimate
Dominant language
JavaScript
Stars
120
Forks
75
PR merge metrics
No merged PRs in 30d

Description

# Problem

We want to add github signup/sign in in addition to the github connect we currently have.

This can be done followingly

## First, we add buttons to the UI

- Add a signup with github button to the signup page. This is basically the connect with github button on the user integration page, just with different test
- Add a sign in with github button to the login page, same as above

__Considering the behavior of the button is about the same, we should rename the existing component and then rewrite it so it yields to content (so we can specify text/content ourselves).__

## Next, we modify our github route

Right now, it sends the code and the state to our API and pushes the returned user into the store.

We should modify this so it also signs the returned user into the session and, if that happens, does not redirect to the `settings.integrations` route and instead redirects to the redirected from route (should be persisted in the session).

## That's it on ember

That should be all there is to it on the side of ember. We can expand later, by, for example, allowing users who signed up through github, to set their password, etc.

The rest is done on the API - https://github.com/code-corps/code-corps-api/issues/9#issuecomment-329185148

@JoshSmith Does this sound like it should be it, or am I missing something?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.