code-charity / code-charity/youtube

🐞"Disable auto dubbing" option doesn't work when defaultDubbedLanguage is set

Open
#3,950 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Feature request good first issue help wanted up-for-grabs
Dominant language
JavaScript
Stars
4.6k
Forks
996
Avg merge
2d 15h
Merged PRs (30d)
7

Description

Description:
When "Disable auto dubbing" and "Hide auto-dubbed options in menu" are both enabled, and a language is selected in defaultDubbedLanguage, YouTube still plays auto-dubbed audio. The "Disable auto dubbing" feature is being ignored.

Steps to reproduce:

  1. Enable Disable auto dubbing
  2. Enable Hide auto-dubbed options in menu
  3. Set a language in defaultDubbedLanguage
  4. Open a video that has auto-dubbing available
  5. Play the video

Expected behavior:
When "Disable auto dubbing" is enabled, auto-dubbed tracks must be completely avoided.
ImprovedTube should first try to use the language from defaultDubbedLanguage (if a real dub for this language exists in the video).
If the selected language is not available, it should fall back to the original audio track.

Environment:

  • ImprovedTube version: from source
  • Browser: Helium
  • OS: Windows 11

Additional context:
This started after updating ImprovedTube from source.

ImprovedTube settings:
improvedtube.json

YouTube root element:
youtube root element.txt

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test entry point is named in the issue. First reproduce the behavior with Disable auto dubbing, Hide auto-dubbed options in menu, and defaultDubbedLanguage enabled, then trace the playback handling for those settings. Done means a real selected-language dub is used when available, otherwise the original audio track is selected and auto-dubbed audio is avoided.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.