code-charity / code-charity/youtube

Remove HD label from 1080p

Open
#1,702 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

💭Question🌱 good first issue help wanted Rare use-case? up-for-grabs
Dominant language
JavaScript
Stars
4.6k
Forks
996
Avg merge
2d 15h
Merged PRs (30d)
7

Description

PROBLEM:
YouTube 1080p looks absolutely terrible, and it doesn't deserve to have HD icon around a quality selector. And the same icon is used for 1440p, which looks decent. For 4k there is another icon.
If a video doesn't have good quality, I can close it immediately, but because of the HD icon I have to manually open the quality setting and watch in case there is 1440p.

SOLUTION:
Simply remove it
image
There is a function aW.prototype.updateBadge in base.js with condition that sets ytp-hd-quality-badge for both 1080 and 1440 that could be simply edited to only match 1440. But I can't figure out how you can edit a private function with extension.

ALTERNATIVES:
Make different icon for 1080p

RELEVANCE / SCOPE:
every self respecting person because youtube video quality is absolutely terrible at low resolutions

"SIDE EFFECTS":

CONTEXT:
//
Thank you!

SHORT Table (Summary)
Problem 1080p doesn't deserve HD icon
Solution Remove HD label from 1080p
Alternatives Make different icon for 1080p
Scope Youtube player
Side effects
Context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in base.js at aW.prototype.updateBadge and inspect the condition that applies ytp-hd-quality-badge to 1080p and 1440p. Confirm the change by checking that 1080p no longer receives the HD label while 1440p still does; the issue does not mention a specific test file.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
39/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.