codaxy / codaxy/conductor-sharp
A typo and a possible misuse of complex type destructuring
Open
- Dominant language
- C#
- Stars
- 7
- Forks
- 6
- Avg merge
- 4h 11m
- Merged PRs (30d)
- 8
Description
In [this line](https://github.com/codaxy/conductor-sharp/blob/ab38211bec5467e0557cff929e464ccd179a0d2d/src/ConductorSharp.Engine/Behaviors/RequestResponseLoggingBehavior.cs#L58C17-L59C55):
1. "occurred" is misspelled (one "r" is missing)
1. Consider using `_logger.LogError(ex, $"Error occurred...", ...)` instead of `_logger.LogError($"Exception {@Exception} occurred...", ex, ...)`
As a sidenote, every exception is logged twice--once with the performance counters and once without, e.g.:
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.