codalab / codalab/codabench

InquiryQuestion about permission validation logic relying on custom checks instead of Django's native system

Open
#1,996 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Discussion
Dominant language
Python
Stars
176
Forks
74
Avg merge
5d 3h
Merged PRs (30d)
21

Description

Hi,

While using Codabench, I noticed some inconsistencies with permission control. Specifically, when I removed the "can add competition" permission from a user group via Django Admin, users in that group could still add competition.
Checking the code (~/competitions/views.py), I found that views like CompetitionCreateForm only require login status (LoginRequiredMixin) without integrating Django's native permission checks (e.g., PermissionRequiredMixin or has_perm()). Instead, permission control generally relies on hardcoded identity checks (e.g., is_superuser, created_by, collaborators), which bypasses Django's group permission system entirely.

I'd like to confirm:
Besides competition creation, which other features use similar custom identity checks instead of Django's native permissions?
Is this design intentional (e.g., for platform-specific needs)? Are there plans to integrate with Django's permission system for more flexible access control?
If full integration isn't feasible, is there documentation on which features use custom logic and their criteria?

Our use case requires role-based permission management (e.g., teachers creating competitions, students only submitting). Clarification would help avoid configuration conflicts.

Thanks for your help!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in ~/competitions/views.py and inspect the views mentioned in the issue for LoginRequiredMixin and custom identity checks. Compare the affected features with Django's native permission behavior, then document the findings or clarify the intended integration scope with maintainers. Done requires an agreed scope for permission handling or documentation of the existing criteria.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
authorization, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.