cockroachdb / cockroachdb/sequelize-cockroachdb

Running migration with umzug has some issues

Open
#19 6 comments 0 reactions 1 assignee Claimed by @benesch View on GitHub
Dominant language
JavaScript
Stars
55
Forks
18
PR merge metrics
No merged PRs in 30d

Description

When running the following migration

```js
'use strict';

module.exports = {
up: (query, types) => {
query.addColumn('Users', 'lastName', types.STRING);
},
down: (query, types) => {
query.removeColumn('Users', 'lastName');
},
};
```
This error is thrown `SequelizeDatabaseError: database "public" does not exist`
the query that it attempted to ran was this:
```
Executing (default): ALTER TABLE "public"."Users" ADD COLUMN "lastName" VARCHAR(255);
```

After digging into the code a little bit I think i tracked this down to this line here in sequelize
https://github.com/sequelize/sequelize/blob/master/lib/dialects/abstract/query-generator.js#L26

You can see they call this function in the postgres query-generator dialect on this line
https://github.com/sequelize/sequelize/blob/master/lib/dialects/postgres/query-generator.js#L241

Versions:
Cockroachdb: CCL v1.1.0-rc.1 @ 2017/10/05 15:33:25 (go1.8.3)
sequelize-cockroachdb: 1.0.2
umzug: 2.0.1

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.