cockroachdb / cockroachdb/pebble
sstable: check bloom filter before generating synthetic key
Open
A-storage
T-storage
- Dominant language
- Go
- Stars
- 6k
- Forks
- 584
- Avg merge
- 16h 35m
- Merged PRs (30d)
- 5
Description
Currently the SeekPrefixGE lazy positioning implementation added in ca74226f0dcd97a53e684f5d0ecd003f3a070c02 generates the synthetic key _before_ checking the bloom filter:
https://github.com/cockroachdb/pebble/blob/3d6e6a15ceb60f6c370e6cf70cf1c2829ce322cb/sstable/reader_iter_single_lvl.go#L872-L930
We should reverse the order, so that we generate fewer synthetic keys and need to perform fewer key comparisons within the heap.
Jira issue: PEBBLE-1297
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.