cockroachdb / cockroachdb/pebble

db: rework ongoing in TestCompactionPickerTargetLevel

Open
#4,411 0 comments 0 reactions 0 assignees View on GitHub
A-storage E-quick-win T-storage
Dominant language
Go
Stars
6k
Forks
584
Avg merge
16h 35m
Merged PRs (30d)
5

Description

In this test we specify ongoing compactions just by their levels, and the test code make some fairly arbitrary choices about which files are part of the compaction, e.g. for some reason Lbase compactions always include the entire base level (?)

We should switch to specifying the exact compactions, perhaps in a format similar to the one we use when logging compactions: `L1 [0001,0002] L2 [0003,00004] -> L5`

Jira issue: PEBBLE-357

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the TestCompactionPickerTargetLevel test and inspect how it currently specifies ongoing compactions by level. Compare that setup with the existing compaction logging format; done means the test specifies exact input files and target levels without relying on arbitrary file-selection behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.