cockroachdb / cockroachdb/pebble

internal/manifest: consider removing Trailer from file boundary keys

Open
#2,106 2 comments 0 reactions 0 assignees View on GitHub
A-storage C-cleanup T-storage
Dominant language
Go
Stars
6k
Forks
584
Avg merge
16h 35m
Merged PRs (30d)
5

Description

Currently, file boundaries are represented using `InternalKey`s, encoding user keys along with sequence number and key kind. Now that user keys are never split between files of a compaction and all existing instances of split user keys have been compacted (since [FormatSplitUserKeysMarkedCompacted](https://github.com/cockroachdb/pebble/blob/8dc60b62ebbfc9295e16e1910d4646b27a4a0770/format_major_version.go#L88-L95) / Cockroach v22.2), the internal key type is unnecessary. We could represent the file boundaries using a simpler type, holding a tuple of (user key, is exclusive).

Jira issue: PEBBLE-174

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.