cockroachdb / cockroachdb/helm-charts

Bug: ServiceMonitor should use https instead of http

Open
#386 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
105
Forks
152
Avg merge
4d 23h
Merged PRs (30d)
5

Description

current `servicemonitor` resources without option scheme, it can only be used for insecure clusters, example like this.

```yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
name: cockroachdb
spec:
endpoints:
- interval: 10s
path: /_status/vars
port: http
# without scheme: https
tlsConfig:
ca:
secret:
key: ca.crt
name: cockroachdb-node
cert:
secret:
key: tls.crt
name: cockroachdb-node
insecureSkipVerify: true
keySecret:
key: tls.key
name: cockroachdb-node
namespaceSelector:
any: true
selector:
matchLabels:
app.kubernetes.io/component: cockroachdb
app.kubernetes.io/instance: cockroachdb
app.kubernetes.io/name: cockroachdb
```

Jira issue: HELM-15

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the Helm chart templates and rendered manifests for the ServiceMonitor endpoint configuration and its default scheme. Render the affected chart with the example TLS settings, then verify that the generated ServiceMonitor uses HTTPS and that existing endpoint options remain intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure, observability
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.