cockroachdb / cockroachdb/helm-charts
Use `tls.enabled` to conditionally render the client rotation cronjob
- Dominant language
- Go
- Stars
- 105
- Forks
- 152
- Avg merge
- 4d 23h
- Merged PRs (30d)
- 5
Description
Currently the certificate rotation cronjob for the clients and nodes is rendered even if `tls.enabled` is disabled.
https://github.com/cockroachdb/helm-charts/blob/da0ac4372c7b34144a904c4999fbc1fb17676895/cockroachdb/templates/cronjob-client-node-certSelfSigner.yaml#L1
The check should be similar to https://github.com/cockroachdb/helm-charts/blob/da0ac4372c7b34144a904c4999fbc1fb17676895/cockroachdb/templates/cronjob-ca-certSelfSigner.yaml#L1
Jira issue: HELM-31
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with cockroachdb/templates/cronjob-client-node-certSelfSigner.yaml and compare its top-level condition with cockroachdb/templates/cronjob-ca-certSelfSigner.yaml. Update the client and node rotation cronjob so it is rendered only when tls.enabled is enabled, then verify the template output for both enabled and disabled settings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, yaml
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100