cockroachdb / cockroachdb/helm-charts

allow custom tlsConfig for serviceMonitor

Open
#180 3 comments 6 reactions 1 assignee Claimed by @prafull01 View on GitHub
Dominant language
Go
Stars
105
Forks
152
Avg merge
4d 23h
Merged PRs (30d)
5

Description

When using your own signed certs it not possible to predict what the pods IPs will be and include them in certificate.
This lead to the following error out of the box:

```
Get "https://10.102.51.143:8080/_status/vars": x509: certificate is valid for 127.0.0.1, not 10.102.51.143
```

Since wildcards IPs is not an option the only way i can think to workarround this is to allow to pass `tlsConfig.insecureSkipVerify` to service monitor

Passing the full `tlsConfig` can also allow to workarround some other use cases like passing the certificate

Unless there is a plan to expose metrics in plain http instead of tls i think this is the best option

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.