cockroachdb / cockroachdb/crlfmt

crlfmt doesn't let me wrap function calls at less than 100 chars

Open
#5 1 comment 0 reactions 1 assignee Claimed by @jordanlewis View on GitHub
bug
Dominant language
Go
Stars
20
Forks
14
PR merge metrics
No merged PRs in 30d

Description

The tool is removing wraps that I've added by hand. I think this is going way too far.
Radu raised the issue too in https://github.com/cockroachdb/cockroach/pull/8823#issuecomment-242508360 but a quick discussion concluded that "less options is better". I'd like to revisit that. If I chose to wrap, let it be.
To lawyer up, this rule is not in the style guide. The style guide has vague wording saying to assume code is gonna be read on 100 cols terminals and to wrap at 100, but I'm pretty sure the intent was to set an upper bound.

```
Before:
func createTestClientForUser(
t *testing.T,
stopper *stop.Stopper,
addr, user string,
dbCtx client.DBContext,
) *client.DB {

After:
func createTestClientForUser(
t *testing.T, stopper *stop.Stopper, addr, user string, dbCtx
) *client.DB {
```

cc @RaduBerinde @knz @paperstreet

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.