cockroachdb / cockroachdb/cockroach

log, redact: redaction markers incorrectly get inserted escape markers and quotes

Open
#99,698 1 comment 0 reactions 0 assignees View on GitHub
C-bug T-supportability
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

It was observed in a slow query log output, that a query containing JSON values could get incorrectly redacted causing the JSON structure of the resulting slow query log to become invalid.

Results like this: `{\"key\": \"0.0\›‹"}` have been observed for values in a JSON map.

Expected behavior: the `›‹` should only be inserted either before or after `\"`

Jira issue: CRDB-26028

Epic CRDB-49080

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.