cockroachdb / cockroachdb/cockroach

sql: ensure the home region savepoint is not broken by pausable portals

Open
#99,408 0 comments 0 reactions 0 assignees View on GitHub
A-pausable-portals C-bug T-sql-queries
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

When re-executing a pausable portal, we re-call the `connExecutor.execStmtInOpenState()`. Originally, the logic in this function is expected to be run only once for each query, so we're not sure if they should be rerun for a portal. This home region savepoint part is an example, and we should confirm its usage.

https://github.com/cockroachdb/cockroach/blob/d8ea15c875bcdce02cc6325037460b2a3ef7054a/pkg/sql/conn_executor_exec.go#L739-L768

Jira issue: CRDB-25869

Epic CRDB-25183

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.