cockroachdb / cockroachdb/cockroach

kv: acquire latches during READ_UNCOMMITTED scans

Open
#98,862 6 comments 0 reactions 0 assignees View on GitHub
A-kv C-bug C-cleanup E-starter T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

READ_UNCOMMITTED BatchRequests do not acquire latches. This dates back to the introduction of the "read consistency type", when it was split off from INCONSISTENT: https://github.com/cockroachdb/cockroach/commit/04b2155f5bf11760c0cae49d36e63671724f4c88#diff-271aa5bd8272fa39bd683ecbf27f1906bafca61dc350ff229c6627fbde697fbaR2121-R2122.

Forgoing latches also forgoes real-time ordering guarantees (see comment added in #98775). This was not the intention, so we should reconsider whether these requests should acquire latches.

Jira issue: CRDB-25553

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.