cockroachdb / cockroachdb/cockroach

sql: include random descriptor states in randomized testing

Open
#97,200 3 comments 0 reactions 0 assignees View on GitHub
A-testing C-investigation O-qa T-sql-foundations
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

In #79613 and #96924 we observed optimizer internal errors during unexpected descriptor states. (In the first case we made the descriptor state invalid, in the second case we will have to fix the optimizer error.)

To catch more cases like this, we should add some random descriptor states to our randomized SQL testing. (Maybe this means adding random ALTERs to sqlsmith, TLP, costfuzz, and unoptimized-query-oracle, or maybe this means creating an entirely new test. Not sure. Whatever we do, we'll need the descriptors to be in unusual states while simultaneously executing DML statements, so a serially-executed ALTER statement that completes before other statements execute might not work.)

Jira issue: CRDB-24571

Epic CRDB-30352

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.