cockroachdb / cockroachdb/cockroach

disaster recovery: remove/fix tests that were ignored from bumping minBinary to V22_2

Open
#95,804 1 comment 0 reactions 0 assignees View on GitHub
A-disaster-recovery C-enhancement T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

In order to bump minBinary to V22_2, we ignored failing tests for future async removal/fixing
- issue: https://github.com/cockroachdb/cockroach/issues/95530
- pr: https://github.com/cockroachdb/cockroach/pull/96656

This issue is to track removing/fixing tests as needed for Disaster Recovery:

pkg/ccl/storageccl/engineccl
- BenchmarkTimeBoundIterate

Contributor guide

Open the contributing guide

Research direction

Start by reviewing issue 95530 and PR 96656, then inspect the ignored BenchmarkTimeBoundIterate in pkg/ccl/storageccl/engineccl. Determine whether the benchmark should be fixed or removed for the V22_2 minimum binary change, and run the relevant storageccl tests or benchmark to confirm it is no longer ignored or failing.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.