cockroachdb / cockroachdb/cockroach
kvserver: audit fatal assertions and downgrade some to test builds only
Open
C-enhancement
quality-friday
T-kv
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
We have a number of assertions in production builds that will crash the node. This is often worse than the problem they're trying to prevent. We should, by default, place assertions behind `buildutil.CrdbTestBuild`.
See https://github.com/cockroachdb/cockroach/pull/94825#issuecomment-1375725100 for an example.
Jira issue: CRDB-23255
Contributor guide
Assessment
This issue has not been assessed yet.