cockroachdb / cockroachdb/cockroach

cli: workload --data-loader=AUTO may use IMPORT when it's not available

Open
#94,136 1 comment 0 reactions 0 assignees View on GitHub
A-testeng-perf C-bug T-testeng
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

See https://github.com/cockroachdb/cockroach/pull/94135.

The `workload` CLI has no way to discover which workloads are bundled with the CRDB binary (which is not local), so it can happen that `./workload init` will fail as a result and `--data-loader=INSERT` has to be passed manually.

This isn't a huge deal since the popular workloads are bundled, but it's annoying.

More context: https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1671712525326569

Jira issue: CRDB-22705

Contributor guide

Open the contributing guide

Research direction

Start by reading the workload CLI handling of --data-loader=AUTO and how it determines which workloads are bundled when the CRDB binary is remote. Reproduce ./workload init for a workload unavailable to IMPORT, then define and verify behavior that avoids selecting an unavailable loader.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.