cockroachdb / cockroachdb/cockroach

contention: consider adding memory accounting for the Txn ID resolver queue

Open
#94,069 0 comments 0 reactions 0 assignees View on GitHub
C-cleanup T-observability
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

I have a heap profile in which `resolverQueueImpl` accounts for about 1.2GiB of heap usage. The profile was obtained when the node was completely overloaded (running TPCH Q21 with concurrency of 750 with GOMEMLIMIT=7.5GiB on the default roachprod machine with 16GB), so the profile should be taken with a grain of salt, yet it shows that this txn id resolver queue can grow significantly, so we should consider adding the memory accounting for this queue.
[pprof.zip](https://github.com/cockroachdb/cockroach/files/10279384/pprof.zip)

![Screen Shot 2022-12-21 at 8 19 06 AM](https://user-images.githubusercontent.com/5135385/208953421-89b20516-a089-4fa7-91de-a4a588fdb2aa.png)

Jira issue: CRDB-22676

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.