cockroachdb / cockroachdb/cockroach
replication: checksums assigned to raft log entries, but never used
Open
A-kv-replication
C-cleanup
C-performance
T-kv
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
We compute a checksum for each Raft log entry here:
https://github.com/cockroachdb/cockroach/blob/da0dacefba5e13119ff7769f95ab33ecd7386490/pkg/kv/kvserver/logstore/logstore.go#L241
However, we never actually verify that the checksum is valid when reading the Raft log.
We should either use this checksum or stop spending resources (proportional to log entry size) computing it.
Jira issue: CRDB-22377
Contributor guide
Assessment
This issue has not been assessed yet.