cockroachdb / cockroachdb/cockroach
multitenant: handle descriptor removal in updateNodeAddress, updateStoreMap
Open
A-multitenancy
C-enhancement
T-kv
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
These comments indicate that descriptors are added and updated but never removed.
https://github.com/cockroachdb/cockroach/blob/1144e9ae196547f3d533647d08cf18813da72a2b/pkg/ccl/kvccl/kvtenantccl/connector.go#L305
https://github.com/cockroachdb/cockroach/blob/1144e9ae196547f3d533647d08cf18813da72a2b/pkg/ccl/kvccl/kvtenantccl/connector.go#L325
Node count is used in this PR and it will be incorrect if nodes are removed.
https://github.com/cockroachdb/cockroach/pull/93325
Jira issue: CRDB-22278
Epic: CRDB-26091
Contributor guide
Assessment
This issue has not been assessed yet.