cockroachdb / cockroachdb/cockroach

release-26.3: sql/sqlstats/sslocal: TestAssociatingStmtStatsWithTxnFingerprint failed

Open
#175,696 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

branch-release-26.3 C-test-failure O-robot release-blocker T-observability
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

sql/sqlstats/sslocal.TestAssociatingStmtStatsWithTxnFingerprint failed on release-26.3 @ 038fbd3b2f63f29429283d3b09c5c551ea69ecf3:

=== RUN   TestAssociatingStmtStatsWithTxnFingerprint
    test_log_scope.go:172: test logs captured to: outputs.zip/logTestAssociatingStmtStatsWithTxnFingerprint690490004
    test_log_scope.go:82: use -show-logs to present logs inline
    sql_stats_test.go:652: -- test log scope end --
test logs left over in: outputs.zip/logTestAssociatingStmtStatsWithTxnFingerprint690490004
--- FAIL: TestAssociatingStmtStatsWithTxnFingerprint (226.91s)
=== RUN   TestAssociatingStmtStatsWithTxnFingerprint/enabled=false
    sql_stats_test.go:629: condition failed to evaluate within 3m45s: from sql_stats_test.go:643: expected 4, got 7
        
        goroutine dump: /mnt/engflow/worker/work/0/exec/bazel-out/k8-fastbuild/testlogs/pkg/sql/sqlstats/sslocal/sslocal_test/run_3_of_3/test.outputs/goroutine_dump_838410151.txt
--- FAIL: TestAssociatingStmtStatsWithTxnFingerprint/enabled=false (225.81s)

Parameters:

  • attempt=1
  • race=true
  • run=3
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachlabs/obs-prs

This test on roachdash | Improve this report!

Jira issue: CRDB-68579

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect pkg/sql/sqlstats/sslocal/sql_stats_test.go around line 643 and review the captured logs from TestAssociatingStmtStatsWithTxnFingerprint. Reproduce the enabled=false failure with the race setting and determine why the expected count is 4 rather than 7. Done means the test reliably passes on release-26.3.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, sql
Domain
databases, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.