cockroachdb / cockroachdb/cockroach

release-26.2.7-rc: sql/sqlstats/sslocal: TestSQLStatsDiscardStatsOnFingerprintLimit failed

Open
#175,558 0 comments 0 reactions 0 assignees View on GitHub
branch-release-26.2.7-rc C-test-failure O-robot release-blocker T-observability
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

sql/sqlstats/sslocal.TestSQLStatsDiscardStatsOnFingerprintLimit [failed](https://mesolite.cluster.engflow.com/invocations/default/0d352d4b-b064-4c0f-87b7-a85b98fab0f2?testReportRun=3&testReportShard=1&testReportAttempt=1#targets-Ly9wa2cvc3FsL3NxbHN0YXRzL3NzbG9jYWw6c3Nsb2NhbF90ZXN0) on release-26.2.7-rc @ [d81e56ae7d745f070c6fbc5095a1eb2574616ebe](https://github.com/cockroachdb/cockroach/commits/d81e56ae7d745f070c6fbc5095a1eb2574616ebe):

```
pkg/util/metric/registry.go:265 +0x103
github.com/cockroachdb/cockroach/pkg/util/metric.(*Registry).Each()
pkg/util/metric/registry.go:265 +0x103
github.com/cockroachdb/cockroach/pkg/util/metric.(*Registry).Each()
pkg/util/metric/registry.go:265 +0x103
github.com/cockroachdb/cockroach/pkg/util/metric.(*Registry).Each()
pkg/util/metric/registry.go:265 +0x103
github.com/cockroachdb/cockroach/pkg/server/status.eachRecordableValue()
recorder.go:1074 +0xbb8
github.com/cockroachdb/cockroach/pkg/server/status.(*MetricsRecorder).GenerateNodeStatus()
recorder.go:913 +0xaa0
github.com/cockroachdb/cockroach/pkg/server.(*Node).writeNodeStatus.func1()
pkg/server/node.go:1576 +0x9d
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunTask()
pkg/util/stop/stopper.go:318 +0x236
github.com/cockroachdb/cockroach/pkg/server.(*Node).writeNodeStatus()
pkg/server/node.go:1575 +0x107
github.com/cockroachdb/cockroach/pkg/server.(*Node).startWriteNodeStatus.func1()
pkg/server/node.go:1538 +0x44
github.com/cockroachdb/cockroach/pkg/util/startup.RunIdempotentWithRetry.func1()
pkg/util/startup/retry.go:116 +0x3e
github.com/cockroachdb/cockroach/pkg/util/startup.RunIdempotentWithRetryEx[go.shape.interface {}]()
pkg/util/startup/retry.go:137 +0x289
github.com/cockroachdb/cockroach/pkg/util/startup.RunIdempotentWithRetry()
pkg/util/startup/retry.go:115 +0xa7
github.com/cockroachdb/cockroach/pkg/server.(*Node).startWriteNodeStatus()
pkg/server/node.go:1535 +0x12a
github.com/cockroachdb/cockroach/pkg/server.(*topLevelServer).PreStart()
pkg/server/server.go:2187 +0x5c30
github.com/cockroachdb/cockroach/pkg/server.(*topLevelServer).PreStart()
pkg/server/server.go:2063 +0x47c8
github.com/cockroachdb/cockroach/pkg/server.(*topLevelServer).PreStart()
pkg/server/server.go:1777 +0x23af
github.com/cockroachdb/cockroach/pkg/server.(*testServer).PreStart()
pkg/server/testserver.go:868 +0xfd
github.com/cockroachdb/cockroach/pkg/server.(*testServer).Start()
pkg/server/testserver.go:946 +0xc4
github.com/cockroachdb/cockroach/pkg/testutils/serverutils.(*wrap).Start()
bazel-out/k8-fastbuild/bin/pkg/testutils/serverutils/ts_control_forwarder_generated.go:14 +0x71
github.com/cockroachdb/cockroach/pkg/testutils/serverutils.StartServerOnlyE()
pkg/testutils/serverutils/test_server_shim.go:301 +0x2a1
github.com/cockroachdb/cockroach/pkg/testutils/serverutils.StartServerOnly()
pkg/testutils/serverutils/test_server_shim.go:316 +0x84
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/sslocal_test.TestSQLStatsDiscardStatsOnFingerprintLimit()
pkg/sql/sqlstats/sslocal/sql_stats_test.go:1645 +0x12b
testing.tRunner()
GOROOT/src/testing/testing.go:1934 +0x21c
testing.(*T).Run.gowrap1()
GOROOT/src/testing/testing.go:1997 +0x44
==================
```

Parameters:
- attempt=1
- race=true
- run=3
- shard=1
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

/cc @cockroachlabs/obs-prs

[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestSQLStatsDiscardStatsOnFingerprintLimit.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)

Jira issue: CRDB-68457

Contributor guide

Open the contributing guide

Research direction

Start with TestSQLStatsDiscardStatsOnFingerprintLimit in pkg/sql/sqlstats/sslocal/sql_stats_test.go and reproduce it with race enabled. Trace the failure through pkg/util/metric/registry.go:265 and pkg/server/status/recorder.go:1074, using the linked test report for details. Done means the test passes reliably on the release branch.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, sql
Domain
databases, observability, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.