cockroachdb / cockroachdb/cockroach

cli: TestConcurrentZip failed

Open
#175,032 2 comments 0 reactions 0 assignees View on GitHub
branch-release-25.4.17-rc C-test-failure O-robot release-blocker T-db-server T-observability
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

cli.TestConcurrentZip [failed](https://mesolite.cluster.engflow.com/invocations/default/7a6f9dd4-7ed0-4d3c-be19-b275cd2ab764?testReportRun=3&testReportShard=11&testReportAttempt=1#targets-Ly9wa2cvY2xpOmNsaV90ZXN0) on release-25.4.17-rc @ [64ef4c83c7e76efda5b59d9c61ea4b61333ebf39](https://github.com/cockroachdb/cockroach/commits/64ef4c83c7e76efda5b59d9c61ea4b61333ebf39):

```
=== RUN TestConcurrentZip
test_log_scope.go:171: test logs captured to: outputs.zip/logTestConcurrentZip1980429556
test_log_scope.go:82: use -show-logs to present logs inline
test_log_scope.go:171: test logs captured to: outputs.zip/logTestConcurrentZip3908398781
[debug --host=127.0.0.1:38329 --insecure=true zip --timeout=30s --cpu-profile-duration=0s --validate-zip-file=false --cluster-name=TestCluster-EGiS3k3oHr /dev/null]
zip_test.go:449:
/mnt/engflow/worker/work/0/exec/bazel-out/k8-fastbuild/bin/pkg/cli/cli_test_/cli_test.runfiles/com_github_cockroachdb_cockroach/pkg/cli/testdata/zip/testzip_concurrent:1:
zip
output didn't match expected:
@@ -1,5 +1,6 @@
+...
[cluster] WARNING: some collected data referenced sensitive cluster settings and was scrubbed; see sensitive_settings_warning.txt inside the zip
[cluster] capture debug zip flags...
[cluster] capture debug zip flags: done
[cluster] capture debug zip flags: writing binary output: debug/debug_zip_command_flags.txt...
[cluster] collecting the inflight traces for jobs...
@@ -174,11 +175,11 @@
[node 3] node status: writing JSON output: debug/nodes/3/status.json...
[node 3] requesting cpu profile list...
[node 3] requesting cpu profile list: creating error output: debug/nodes/3/cpuprof.err.txt...
[node 3] requesting cpu profile list: done
[node 3] requesting cpu profile list: last request failed: rpc error: ...
-[node 3] requesting cpu profile list: received response...
+[node 3] requesting cpu profile list: received responseWARNING: 1 log entries in clitest.8d18ea52-e561-42c9-940a-fda261eb9494.roach.2026-09-11T08_08_22Z.000055.log mentioned sensitive cluster settings and were scrubbed client-side (0 were not redactable and were replaced entirely)
[node 3] requesting data for debug/nodes/3/details...
[node 3] requesting data for debug/nodes/3/details: done
[node 3] requesting data for debug/nodes/3/details: received response...
[node 3] requesting data for debug/nodes/3/details: writing JSON output: debug/nodes/3/details.json...
[node 3] requesting data for debug/nodes/3/gossip...
panic.go:635: -- test log scope end --
test logs left over in: outputs.zip/logTestConcurrentZip3908398781
panic.go:635: -- test log scope end --
--- FAIL: TestConcurrentZip (18.17s)
```

Parameters:
- attempt=1
- deadlock=true
- run=3
- shard=11
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

Same failure on other branches

- #174810 cli: TestConcurrentZip failed [C-test-failure O-robot T-observability branch-release-25.2.24-rc release-blocker]

/cc @cockroachlabs/obs-prs @cockroachlabs/server @cockroachlabs/obs-india-prs

[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestConcurrentZip.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)

Contributor guide

Open the contributing guide

Research direction

Start with TestConcurrentZip in pkg/cli/zip_test.go around line 449 and the expected output in pkg/cli/testdata/zip/testzip_concurrent. Reproduce the failure and inspect the captured logs, especially the sensitive-settings warning and concurrent test-log handling. Done means the test is reliable and its output matches the expected fixture without leftover logs.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, observability, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.