cockroachdb / cockroachdb/cockroach

basalt-26.3: sql/importer: TestCSVImportMarksFilesFullyProcessed failed

Closed
#174,927 3 comments 0 reactions 0 assignees View on GitHub
branch-basalt-26.3 C-test-failure O-robot release-blocker T-sql-foundations
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

sql/importer.TestCSVImportMarksFilesFullyProcessed [failed](https://mesolite.cluster.engflow.com/invocations/default/376fcf97-274a-4e7c-ad0a-4aafab7d24f7?testReportRun=1&testReportShard=3&testReportAttempt=1#targets-Ly9wa2cvc3FsL2ltcG9ydGVyOmltcG9ydGVyX3Rlc3Q=) on basalt-26.3 @ [c6d01ae4be9708178b248a49819b505daf713377](https://github.com/cockroachdb/cockroach/commits/c6d01ae4be9708178b248a49819b505daf713377):

```
external/org_golang_x_sync/errgroup/errgroup.go:93 +0x86

Previous read at 0x00c01b081718 by goroutine 11968:
github.com/cockroachdb/cockroach/pkg/kv/bulk.(*kvBuf).Len()
pkg/kv/bulk/kv_buf.go:177 +0x2e
github.com/cockroachdb/cockroach/pkg/kv/bulk.(*BufferingAdder).IsEmpty()
pkg/kv/bulk/buffering_adder.go:271 +0xe
github.com/cockroachdb/cockroach/pkg/sql/bulksst.(*BulkAdderSink).IsEmpty()
:1 +0x3a
github.com/cockroachdb/cockroach/pkg/sql/importer.(*importProgressTracker).flushedRowsForSink()
pkg/sql/importer/import_processor.go:679 +0x4e8
github.com/cockroachdb/cockroach/pkg/sql/importer.(*importProgressTracker).formatProgress()
pkg/sql/importer/import_processor.go:639 +0x556
github.com/cockroachdb/cockroach/pkg/sql/importer.ingestKvs.func1()
pkg/sql/importer/import_processor.go:349 +0x8f
github.com/cockroachdb/cockroach/pkg/sql/importer.ingestKvs.func3()
pkg/sql/importer/import_processor.go:453 +0x20a
github.com/cockroachdb/cockroach/pkg/sql/importer.ingestKvs.Group.GoCtx.func5()
pkg/util/ctxgroup/ctxgroup.go:200 +0x115
golang.org/x/sync/errgroup.(*Group).Go.func1()
external/org_golang_x_sync/errgroup/errgroup.go:93 +0x86

Goroutine 11969 (running) created at:
golang.org/x/sync/errgroup.(*Group).Go()
external/org_golang_x_sync/errgroup/errgroup.go:78 +0x11c
github.com/cockroachdb/cockroach/pkg/util/ctxgroup.Group.GoCtx()
pkg/util/ctxgroup/ctxgroup.go:191 +0x1809
github.com/cockroachdb/cockroach/pkg/sql/importer.ingestKvs()
pkg/sql/importer/import_processor.go:460 +0x1457
github.com/cockroachdb/cockroach/pkg/sql/importer.runImport.func2()
pkg/sql/importer/read_import_base.go:127 +0xdb
github.com/cockroachdb/cockroach/pkg/sql/importer.runImport.Group.GoCtx.func5()
pkg/util/ctxgroup/ctxgroup.go:200 +0x115
golang.org/x/sync/errgroup.(*Group).Go.func1()
external/org_golang_x_sync/errgroup/errgroup.go:93 +0x86

Goroutine 11968 (running) created at:
golang.org/x/sync/errgroup.(*Group).Go()
external/org_golang_x_sync/errgroup/errgroup.go:78 +0x11c
github.com/cockroachdb/cockroach/pkg/util/ctxgroup.Group.GoCtx()
pkg/util/ctxgroup/ctxgroup.go:191 +0x1456
github.com/cockroachdb/cockroach/pkg/sql/importer.ingestKvs()
pkg/sql/importer/import_processor.go:442 +0x1285
github.com/cockroachdb/cockroach/pkg/sql/importer.runImport.func2()
pkg/sql/importer/read_import_base.go:127 +0xdb
github.com/cockroachdb/cockroach/pkg/sql/importer.runImport.Group.GoCtx.func5()
pkg/util/ctxgroup/ctxgroup.go:200 +0x115
golang.org/x/sync/errgroup.(*Group).Go.func1()
external/org_golang_x_sync/errgroup/errgroup.go:93 +0x86
==================
```

Parameters:
- attempt=1
- race=true
- run=1
- shard=3
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

/cc @cockroachlabs/sql-foundations

[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestCSVImportMarksFilesFullyProcessed.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)

Jira issue: CRDB-68098

Contributor guide

Open the contributing guide

Research direction

Start with sql/importer.TestCSVImportMarksFilesFullyProcessed and run it with race detection. Read pkg/sql/importer/import_processor.go around ingestKvs, formatProgress, and flushedRowsForSink, then follow the accesses into pkg/sql/bulksst and pkg/kv/bulk/kv_buf.go and buffering_adder.go. Done means the test passes without the reported data race.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.