cockroachdb / cockroachdb/cockroach
cli: TestConcurrentZip failed
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
cli.TestConcurrentZip [failed](https://mesolite.cluster.engflow.com/invocations/default/49e9d96a-ccb3-4556-a8dd-3d4973c2374b?testReportRun=3&testReportShard=4&testReportAttempt=1#targets-Ly9wa2cvY2xpOmNsaV90ZXN0) on release-25.2.24-rc @ [92c7311721160180bed1228023264f6df947fc1e](https://github.com/cockroachdb/cockroach/commits/92c7311721160180bed1228023264f6df947fc1e):
```
=== RUN TestConcurrentZip
test_log_scope.go:165: test logs captured to: outputs.zip/logTestConcurrentZip3143581416
test_log_scope.go:76: use -show-logs to present logs inline
test_log_scope.go:165: test logs captured to: outputs.zip/logTestConcurrentZip3199557457
[debug --host=127.0.0.1:36165 --insecure=true zip --timeout=30s --cpu-profile-duration=0s --cluster-name=TestCluster-INllNGwOnu /dev/null]
zip_test.go:448:
/mnt/engflow/worker/work/3/exec/bazel-out/k8-fastbuild/bin/pkg/cli/cli_test_/cli_test.runfiles/com_github_cockroachdb_cockroach/pkg/cli/testdata/zip/testzip_concurrent:1:
zip
output didn't match expected:
@@ -1,5 +1,6 @@
+...
[cluster] WARNING: some collected data referenced sensitive cluster settings and was scrubbed; see sensitive_settings_warning.txt inside the zip
[cluster] capture debug zip flags...
[cluster] capture debug zip flags: done
[cluster] capture debug zip flags: writing binary output: debug/debug_zip_command_flags.txt...
[cluster] collecting the inflight traces for jobs...
@@ -138,11 +139,11 @@
[node 2] requesting heap profile list: last request failed: rpc error: ...
[node 2] requesting heap profile list: received response...
[node 2] requesting heap profile...
[node 2] requesting heap profile: done
[node 2] requesting heap profile: received response...
-[node 2] requesting heap profile: writing binary output: debug/nodes/2/heap.pprof...
+[node 2] requesting heap profile: writing binary output: debug/nodes/2/heap.pprofWARNING: 1 log entries in clitest.2bff8d33-21cf-4410-8eda-05efff477427.roach.2026-09-07T07_52_44Z.000101.log mentioned sensitive cluster settings and were scrubbed client-side (0 were not redactable and were replaced entirely)
[node 2] requesting log files list...
[node 2] requesting log files list: done
[node 2] requesting log files list: received response...
[node 2] requesting ranges...
[node 2] requesting ranges: done
panic.go:635: -- test log scope end --
panic.go:635: -- test log scope end --
test logs left over in: outputs.zip/logTestConcurrentZip3199557457
--- FAIL: TestConcurrentZip (17.48s)
```
Parameters:
- attempt=1
- deadlock=true
- run=3
- shard=4
Help
See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)
/cc @cockroachlabs/obs-prs @cockroachlabs/server @cockroachlabs/obs-india-prs
[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestConcurrentZip.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)
Contributor guide
Research direction
Start with TestConcurrentZip in pkg/cli/zip_test.go and its expected output in pkg/cli/testdata/zip/testzip_concurrent. Reproduce the focused test and inspect the concurrent log output around heap profile writing and sensitive-settings warnings. Done means the test passes reliably with the expected output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100