cockroachdb / cockroachdb/cockroach

basalt-26.3: pkg/sql/sqlstats/insights/integration/integration_test: TestTransactionInsightsFailOnCommit failed

Open
#174,696 2 comments 0 reactions 0 assignees View on GitHub
branch-basalt-26.3 C-test-failure O-robot release-blocker T-observability
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

pkg/sql/sqlstats/insights/integration/integration_test.TestTransactionInsightsFailOnCommit [failed](https://mesolite.cluster.engflow.com/invocations/default/22e193ae-13db-4b11-9efe-450a9f57dcbf?testReportRun=3&testReportShard=1&testReportAttempt=1#targets-Ly9wa2cvc3FsL3NxbHN0YXRzL2luc2lnaHRzL2ludGVncmF0aW9uOmludGVncmF0aW9uX3Rlc3Q=) on basalt-26.3 @ [7b7d64a360fe4249bf6409fb266081ab370be355](https://github.com/cockroachdb/cockroach/commits/7b7d64a360fe4249bf6409fb266081ab370be355):

```
=== RUN TestTransactionInsightsFailOnCommit
test_log_scope.go:172: test logs captured to: outputs.zip/logTestTransactionInsightsFailOnCommit2109232832
test_log_scope.go:82: use -show-logs to present logs inline
test_server_shim.go:168: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.
insights_test.go:718: -- test log scope end --
test logs left over in: outputs.zip/logTestTransactionInsightsFailOnCommit2109232832
--- FAIL: TestTransactionInsightsFailOnCommit (78.17s)
=== RUN TestTransactionInsightsFailOnCommit/enable_recording_SERIALIZATION_CONFLICT_events=true
insights_test.go:626:
Error Trace: pkg/sql/sqlstats/insights/integration/insights_test.go:626
pkg/testutils/subtest.go:23
Error: An error is expected but got nil.
Test: TestTransactionInsightsFailOnCommit/enable_recording_SERIALIZATION_CONFLICT_events=true
--- FAIL: TestTransactionInsightsFailOnCommit/enable_recording_SERIALIZATION_CONFLICT_events=true (7.81s)
```

Parameters:
- attempt=1
- race=true
- run=3
- shard=1
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

Same failure on other branches

- #174652 pkg/sql/sqlstats/insights/integration/integration_test: TestTransactionInsightsFailOnCommit failed [C-test-failure O-robot T-observability branch-master release-blocker]

/cc @cockroachlabs/obs-prs

[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestTransactionInsightsFailOnCommit.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)

Jira issue: CRDB-67915

Contributor guide

Open the contributing guide

Research direction

Start with pkg/sql/sqlstats/insights/integration/insights_test.go, especially TestTransactionInsightsFailOnCommit and the failure at line 626. Reproduce the failure at commit 7b7d64a360fe4249bf6409fb266081ab370be355 with race=true, then inspect the captured test logs. Done means the test reliably receives the expected commit error, including for SERIALIZATION_CONFLICT recording.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, sql
Domain
databases, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.