cockroachdb / cockroachdb/cockroach
pkg/sql/sqlstats/insights/integration/integration_test: TestTransactionInsightsFailOnCommit failed
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
pkg/sql/sqlstats/insights/integration/integration_test.TestTransactionInsightsFailOnCommit [failed](https://mesolite.cluster.engflow.com/invocations/default/4ee7069a-aa04-4b33-b374-7bfe7de4d6c9?testReportRun=1&testReportShard=1&testReportAttempt=1#targets-Ly9wa2cvc3FsL3NxbHN0YXRzL2luc2lnaHRzL2ludGVncmF0aW9uOmludGVncmF0aW9uX3Rlc3Q=) on master @ [5ad5267944c4bc0604b8eb9d2d95f1589b9a939b](https://github.com/cockroachdb/cockroach/commits/5ad5267944c4bc0604b8eb9d2d95f1589b9a939b):
```
=== RUN TestTransactionInsightsFailOnCommit
test_log_scope.go:172: test logs captured to: outputs.zip/logTestTransactionInsightsFailOnCommit441895060
test_log_scope.go:82: use -show-logs to present logs inline
test_server_shim.go:168: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.
insights_test.go:757: -- test log scope end --
test logs left over in: outputs.zip/logTestTransactionInsightsFailOnCommit441895060
--- FAIL: TestTransactionInsightsFailOnCommit (80.03s)
=== RUN TestTransactionInsightsFailOnCommit/enable_recording_SERIALIZATION_CONFLICT_events=true
insights_test.go:665:
Error Trace: pkg/sql/sqlstats/insights/integration/insights_test.go:665
pkg/testutils/subtest.go:23
Error: An error is expected but got nil.
Test: TestTransactionInsightsFailOnCommit/enable_recording_SERIALIZATION_CONFLICT_events=true
--- FAIL: TestTransactionInsightsFailOnCommit/enable_recording_SERIALIZATION_CONFLICT_events=true (14.44s)
```
Parameters:
- attempt=1
- race=true
- run=1
- shard=1
Help
See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)
/cc @cockroachlabs/obs-prs
[Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)
Jira issue: CRDB-67849
Contributor guide
Research direction
Start with pkg/sql/sqlstats/insights/integration/insights_test.go around the failing assertion at line 665 and reproduce TestTransactionInsightsFailOnCommit, especially the enable_recording_SERIALIZATION_CONFLICT_events=true case. Inspect the captured test logs from outputs.zip/logTestTransactionInsightsFailOnCommit441895060; done means the test reliably receives the expected commit error and passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- databases, observability
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100