cockroachdb / cockroachdb/cockroach
basalt-26.3.1-rc: kv/kvserver: TestPrepareSplitManifestsDataDriven failed
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
kv/kvserver.TestPrepareSplitManifestsDataDriven [failed](https://mesolite.cluster.engflow.com/invocations/default/6794c952-c9cd-4d74-b955-d80520562956?testReportRun=1&testReportShard=46&testReportAttempt=1#targets-Ly9wa2cva3Yva3ZzZXJ2ZXI6a3ZzZXJ2ZXJfdGVzdA==) on basalt-26.3.1-rc @ [63bc2c6772a94c6d763293cd0c2ec06e359c0a36](https://github.com/cockroachdb/cockroach/commits/63bc2c6772a94c6d763293cd0c2ec06e359c0a36):
```
| github.com/cockroachdb/pebble.(*DB).ingest(_, {_, _}, {{{0xc02a493530, 0x1, 0x1}, {0x0, 0x0, 0x0}}, {0x0, ...}, ...})
| external/com_github_cockroachdb_pebble/ingest.go:2498 +0x15be
| github.com/cockroachdb/pebble.(*DB).IngestWithHandle(0xc01caaf208, {0xce47598, 0xc027ba8500}, {0xc003d50ff8, 0x1, 0xc003d50f98?}, {0x0, 0x0})
| external/com_github_cockroachdb_pebble/ingest.go:1798 +0x4f6
| github.com/cockroachdb/cockroach/pkg/storage.(*pebbleRSEngine).ingest(0xc01e91aa80, {0xc025ad5800, 0x1, 0x0?}, {0x0, 0x0})
| pkg/storage/rs_engine_pebble.go:116 +0x35b
| github.com/cockroachdb/cockroach/pkg/storage.(*pebbleRSEngine).flushSSTables(0xc01e91aa80, {0xc025ad5800, 0x1, 0x1}, 0x0)
| pkg/storage/rs_engine_pebble.go:102 +0x109
| github.com/cockroachdb/cockroach/pkg/storage.(*rsEngineContainer).FlushSSTables(0xc01c378000, {0xc025ad5800, 0x1, 0x1}, 0x0)
| pkg/storage/rs_engine_container.go:241 +0x115
| github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.installTestManifestForKey(0xc027ca6008, 0xc014216808, {0xcef85d8, 0xc001f18100}, {0xc026f42d78, 0x1, 0x8})
| pkg/kv/kvserver/client_basalt_manifest_helpers_test.go:159 +0x844
| github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.(*splitManifestTestEnv).installTestManifest(...)
| pkg/kv/kvserver/client_split_manifest_test.go:58
| github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.testPrepareSplitManifestsDataDriven.func1.3(0xc027ca6008, 0xc003bdf078)
| pkg/kv/kvserver/client_split_manifest_test.go:292 +0x790
| github.com/cockroachdb/datadriven.RunTest.func1({0xcf03a58, 0xc027ca6008}, 0xc003bdf078)
| external/com_github_cockroachdb_datadriven/datadriven.go:120 +0x59
| github.com/cockroachdb/datadriven.runDirective.func1({0xcf03a58, 0xc027ca6008}, 0xc003bdf078, 0xc025ad5720)
| external/com_github_cockroachdb_datadriven/datadriven.go:367 +0x2b3
| github.com/cockroachdb/datadriven.runDirective({0xcf03a58, 0xc027ca6008}, 0xc003bdf050, 0xc025ad5720)
| external/com_github_cockroachdb_datadriven/datadriven.go:373 +0x95
| github.com/cockroachdb/datadriven.runDirectiveOrSubTest({0xcf03a58, 0xc027ca6008}, 0xc003bdf050, {0x0, 0x0}, 0xc025ad5720)
| external/com_github_cockroachdb_datadriven/datadriven.go:215 +0xa5
| github.com/cockroachdb/datadriven.runTestInternal({0xcf03a58, 0xc027ca6008}, {0xc01da94000, 0xcf}, {0xcdd8780, 0xc025794248}, 0xc025ad5720, 0x0)
| external/com_github_cockroachdb_datadriven/datadriven.go:188 +0xe5
| github.com/cockroachdb/datadriven.RunTestAny({0xcf03a58, 0xc027ca6008}, {0xc01da94000, 0xcf}, 0xc025ad5720)
| external/com_github_cockroachdb_datadriven/datadriven.go:148 +0x3dc
| github.com/cockroachdb/datadriven.RunTest(0xc027ca6008, {0xc01da94000, 0xcf}, 0xc0162832c0)
| external/com_github_cockroachdb_datadriven/datadriven.go:119 +0xb8
| github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.testPrepareSplitManifestsDataDriven.func1(0xc027ca6008, {0xc01da94000, 0xcf})
| pkg/kv/kvserver/client_split_manifest_test.go:289 +0x536
| github.com/cockroachdb/datadriven.Walk.func1({0xcf03a58, 0xc027ca6008}, {0xc01da94000, 0xcf})
| external/com_github_cockroachdb_datadriven/datadriven.go:451 +0x5f
| github.com/cockroachdb/datadriven.WalkAny({0xcf03a58, 0xc027ca6008}, {0xc01da94000, 0xcf}, 0xc002062170)
| external/com_github_cockroachdb_datadriven/datadriven.go:462 +0x27b
| github.com/cockroachdb/datadriven.WalkAny.func1({0xcf03a58, 0xc027ca6008})
| external/com_github_cockroachdb_datadriven/datadriven.go:475 +0xfb
| github.com/cockroachdb/datadriven.subTest.func1(0xc027ca6008)
| external/com_github_cockroachdb_datadriven/test_interface.go:27 +0x3c
| testing.tRunner(0xc027ca6008, 0xc00216a1a0)
| GOROOT/src/testing/testing.go:2036 +0x21d
| created by testing.(*T).Run in goroutine 38153
| GOROOT/src/testing/testing.go:2101 +0xb13
Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *errbase.opaqueWrapper (4) *errutil.withPrefix (5) *errbase.opaqueWrapper (6) *errutil.leafError
Test: TestPrepareSplitManifestsDataDriven/pebble/split_manifest
datadriven.go:343:
fatal during /mnt/engflow/worker/work/0/exec/bazel-out/k8-fastbuild/bin/pkg/kv/kvserver/kvserver_test_/kvserver_test.runfiles/com_github_cockroachdb_cockroach/pkg/kv/kvserver/testdata/split_manifest/pebble/split_manifest:2:
--- FAIL: TestPrepareSplitManifestsDataDriven/pebble/split_manifest (8.52s)
```
Parameters:
- attempt=1
- race=true
- run=1
- shard=46
Help
See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)
/cc @cockroachlabs/kv-triage
[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestPrepareSplitManifestsDataDriven.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)
Jira issue: CRDB-67208
Contributor guide
Research direction
Start by running kv/kvserver.TestPrepareSplitManifestsDataDriven/pebble/split_manifest with the reported race configuration and read pkg/kv/kvserver/client_split_manifest_test.go. Trace the failure through installTestManifestForKey in client_basalt_manifest_helpers_test.go and the reported storage call sites. Done means the test no longer fails under the reported basalt configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- databases, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100