cockroachdb / cockroachdb/cockroach

basalt-26.3.1-rc: kv/kvserver: TestSnapshotHardlinksRSManifest failed

Open
#173,906 0 comments 0 reactions 0 assignees View on GitHub
branch-basalt-26.3.1-rc C-bug C-test-failure O-robot P-0 T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

kv/kvserver.TestSnapshotHardlinksRSManifest [failed](https://mesolite.cluster.engflow.com/invocations/default/6794c952-c9cd-4d74-b955-d80520562956?testReportRun=1&testReportShard=39&testReportAttempt=1#targets-Ly9wa2cva3Yva3ZzZXJ2ZXI6a3ZzZXJ2ZXJfdGVzdA==) on basalt-26.3.1-rc @ [63bc2c6772a94c6d763293cd0c2ec06e359c0a36](https://github.com/cockroachdb/cockroach/commits/63bc2c6772a94c6d763293cd0c2ec06e359c0a36):

```
| pkg/rpc/context.go:918 +0x89
| github.com/cockroachdb/cockroach/pkg/rpc.makeInternalClientAdapter.func2({0xce47598, 0xc01c15fa40}, {0x3?, 0x2?}, {0xc824380, 0xc01723e840}, {0xc660880, 0xc02c724580}, 0x20?, {0x0, ...})
| pkg/rpc/context.go:817 +0x76
| github.com/cockroachdb/cockroach/pkg/rpc.NewContext.ClientInterceptor.func13({0xce47598, 0xc01c15fa40}, {0xc9bdecc, 0x21}, {0xc824380, 0xc01723e840}, {0xc660880, 0xc02c724580}, 0x0, 0xc0269e6600, ...)
| pkg/util/tracing/grpcinterceptor/grpc_interceptor.go:185 +0x4fd
| github.com/cockroachdb/cockroach/pkg/rpc.makeInternalClientAdapter.getChainUnaryInvoker.func4({0xce47598, 0xc01c15fa40}, {0xc9bdecc, 0x21}, {0xc824380, 0xc01723e840}, {0xc660880, 0xc02c724580}, 0x0, {0x0, ...})
| pkg/rpc/context.go:1002 +0x18d
| github.com/cockroachdb/cockroach/pkg/rpc.makeInternalClientAdapter.func3({0xce47598, 0xc01c15f9a0}, 0xc01723e6e0)
| pkg/rpc/context.go:887 +0x467
| github.com/cockroachdb/cockroach/pkg/rpc.internalClientAdapter.Batch(...)
| pkg/rpc/context.go:1010
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*grpcTransport).sendBatch(0xc028008960, {0xce47598, 0xc01c15f9a0}, 0x50d991?, {0xcdff248, 0xc01b6fe480}, 0xc01723e6e0)
| pkg/kv/kvclient/kvcoord/transport.go:229 +0x3ac
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*grpcTransport).SendNext(0xc028008960, {0xce47598, 0xc01c15f9a0}, 0xc01723e6e0)
| pkg/kv/kvclient/kvcoord/transport.go:191 +0x135
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.raceTransport.SendNext({{0xcea3f18?, 0xc028008960?}}, {0xce47598, 0xc01c15f9a0}, 0xc01723e6e0)
| pkg/kv/kvclient/kvcoord/transport_race.go:70 +0x2df
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).sendToReplicas(0xc01b714708, {0xce47598, 0xc01c15f9a0}, 0xc01723e580, {0xc0012a24d0, 0xc01c860d00}, 0x0)
| pkg/kv/kvclient/kvcoord/dist_sender.go:2923 +0x2a2e
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).sendPartialBatch(0xc01b714708, {0xce47598, 0xc01c15f9a0}, 0xc01723e580, {{0xc002402d78, 0x1, 0x8}, {0xc002402d88, 0x2, 0x8}}, ...)
| pkg/kv/kvclient/kvcoord/dist_sender.go:2333 +0x925
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).divideAndSendBatchToRanges(0xc01b714708, {0xce47598, 0xc01c15f9a0}, 0xc01723e580, {{0xc002402d78, 0x1, 0x8}, {0xc002402d88, 0x2, 0x8}}, ...)
| pkg/kv/kvclient/kvcoord/dist_sender.go:1879 +0xf87
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).Send(0xc01b714708, {0xce47598, 0xc02e82e460}, 0xc01723e580)
| pkg/kv/kvclient/kvcoord/dist_sender.go:1384 +0x80e
| github.com/cockroachdb/cockroach/pkg/kv.(*CrossRangeTxnWrapperSender).Send(0xc0027de7f8, {0xce47598, 0xc02e82e460}, 0xc01723e580)
| pkg/kv/db.go:232 +0x1e2
| github.com/cockroachdb/cockroach/pkg/kv.SendWrappedWithAdmission({_, _}, {_, _}, {{0x0, 0x0}, 0x0, {0x0, 0x0}, {0x0, ...}, ...}, ...)
| pkg/kv/sender.go:498 +0x224
| github.com/cockroachdb/cockroach/pkg/kv.SendWrappedWith(...)
| pkg/kv/sender.go:483
| github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*ReplicaManifestCommitter).InstallNewManifest(0xc02534d008, 0x0, {{{0xc002403ee1, 0xf}, 0x42}, {0xc021fec078, 0x1, 0x1}}, {0x0, 0x0})
| pkg/kv/kvserver/replica_manifest_committer.go:258 +0xc57
| github.com/cockroachdb/cockroach/pkg/storage.(*TestingRSEngine).flushSSTables(0xc029cd8c60, {0xc028a939d0, 0x1, 0xc000128008?}, 0x0)
| pkg/storage/rs_engine_testing.go:431 +0xf12
| github.com/cockroachdb/cockroach/pkg/storage.(*rsEngineContainer).FlushSSTables(0xc01b9fa9c0, {0xc028a939d0, 0x1, 0x1}, 0x0)
| pkg/storage/rs_engine_container.go:241 +0x115
| github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.installTestManifestForKey(0xc01741cd88, 0xc01b893008, {0xcef85d8, 0xc0019bfd80}, {0xc02517a5f8, 0x1, 0x8})
| pkg/kv/kvserver/client_basalt_manifest_helpers_test.go:159 +0x844
| github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.TestSnapshotHardlinksRSManifest(0xc01741cd88)
| pkg/kv/kvserver/client_snapshot_manifest_test.go:94 +0x86a
| testing.tRunner(0xc01741cd88, 0xcd8bd28)
| GOROOT/src/testing/testing.go:2036 +0x21d
| created by testing.(*T).Run in goroutine 1
| GOROOT/src/testing/testing.go:2101 +0xb13
Error types: (1) *errbase.opaqueWrapper (2) *errutil.withPrefix (3) *errbase.opaqueWrapper (4) *errutil.leafError
Test: TestSnapshotHardlinksRSManifest
panic.go:694: -- test log scope end --
test logs left over in: outputs.zip/logTestSnapshotHardlinksRSManifest3057781498
--- FAIL: TestSnapshotHardlinksRSManifest (8.04s)
```

Parameters:
- attempt=1
- race=true
- run=1
- shard=39
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

/cc @cockroachlabs/kv-triage

[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestSnapshotHardlinksRSManifest.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)

Jira issue: CRDB-67205

Contributor guide

Open the contributing guide

Research direction

Start by reproducing kv/kvserver_test.TestSnapshotHardlinksRSManifest, using the failure report and its race=true parameters. Read pkg/kv/kvserver/client_snapshot_manifest_test.go, client_basalt_manifest_helpers_test.go, and the manifest installation path through pkg/storage/rs_engine_testing.go. Done means the test passes reliably under the reported configuration and the failure is addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.