cockroachdb / cockroachdb/cockroach

basalt-26.3.1-rc: kv/kvserver: TestGetSnapshotRSEngineSnapshot failed

Open
#173,905 0 comments 0 reactions 0 assignees View on GitHub
branch-basalt-26.3.1-rc C-bug C-test-failure O-robot P-0 T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

kv/kvserver.TestGetSnapshotRSEngineSnapshot [failed](https://mesolite.cluster.engflow.com/invocations/default/6794c952-c9cd-4d74-b955-d80520562956?testReportRun=1&testReportShard=38&testReportAttempt=1#targets-Ly9wa2cva3Yva3ZzZXJ2ZXI6a3ZzZXJ2ZXJfdGVzdA==) on basalt-26.3.1-rc @ [63bc2c6772a94c6d763293cd0c2ec06e359c0a36](https://github.com/cockroachdb/cockroach/commits/63bc2c6772a94c6d763293cd0c2ec06e359c0a36):

```
| pkg/rpc/context.go:918 +0x89
| github.com/cockroachdb/cockroach/pkg/rpc.makeInternalClientAdapter.func2({0xce47598, 0xc015e92dc0}, {0x1b00000000?, 0x2?}, {0xc824380, 0xc0045e8160}, {0xc660880, 0xc0239c6580}, 0x28?, {0x0, ...})
| pkg/rpc/context.go:817 +0x76
| github.com/cockroachdb/cockroach/pkg/rpc.NewContext.ClientInterceptor.func13({0xce47598, 0xc015e92dc0}, {0xc9bdecc, 0x21}, {0xc824380, 0xc0045e8160}, {0xc660880, 0xc0239c6580}, 0x0, 0xc01e833230, ...)
| pkg/util/tracing/grpcinterceptor/grpc_interceptor.go:185 +0x4fd
| github.com/cockroachdb/cockroach/pkg/rpc.makeInternalClientAdapter.getChainUnaryInvoker.func4({0xce47598, 0xc015e92dc0}, {0xc9bdecc, 0x21}, {0xc824380, 0xc0045e8160}, {0xc660880, 0xc0239c6580}, 0x0, {0x0, ...})
| pkg/rpc/context.go:1002 +0x18d
| github.com/cockroachdb/cockroach/pkg/rpc.makeInternalClientAdapter.func3({0xce47598, 0xc015e92d20}, 0xc015ed1a20)
| pkg/rpc/context.go:887 +0x467
| github.com/cockroachdb/cockroach/pkg/rpc.internalClientAdapter.Batch(...)
| pkg/rpc/context.go:1010
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*grpcTransport).sendBatch(0xc01d766f00, {0xce47598, 0xc015e92d20}, 0x50d991?, {0xcdff248, 0xc0017904e0}, 0xc015ed1a20)
| pkg/kv/kvclient/kvcoord/transport.go:229 +0x3ac
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*grpcTransport).SendNext(0xc01d766f00, {0xce47598, 0xc015e92d20}, 0xc015ed1a20)
| pkg/kv/kvclient/kvcoord/transport.go:191 +0x135
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.raceTransport.SendNext({{0xcea3f18?, 0xc01d766f00?}}, {0xce47598, 0xc015e92d20}, 0xc015ed1a20)
| pkg/kv/kvclient/kvcoord/transport_race.go:70 +0x2df
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).sendToReplicas(0xc021fa1508, {0xce47598, 0xc015e92d20}, 0xc015ed1760, {0xc022647ce0, 0xc0148c7400}, 0x0)
| pkg/kv/kvclient/kvcoord/dist_sender.go:2923 +0x2a2e
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).sendPartialBatch(0xc021fa1508, {0xce47598, 0xc015e92d20}, 0xc015ed1760, {{0xc036722698, 0x1, 0x8}, {0xc0367226a8, 0x2, 0x8}}, ...)
| pkg/kv/kvclient/kvcoord/dist_sender.go:2333 +0x925
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).divideAndSendBatchToRanges(0xc021fa1508, {0xce47598, 0xc015e92d20}, 0xc015ed1760, {{0xc036722698, 0x1, 0x8}, {0xc0367226a8, 0x2, 0x8}}, ...)
| pkg/kv/kvclient/kvcoord/dist_sender.go:1879 +0xf87
| github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*DistSender).Send(0xc021fa1508, {0xce47598, 0xc01fd280a0}, 0xc015ed1760)
| pkg/kv/kvclient/kvcoord/dist_sender.go:1384 +0x80e
| github.com/cockroachdb/cockroach/pkg/kv.(*CrossRangeTxnWrapperSender).Send(0xc0047423d8, {0xce47598, 0xc01fd280a0}, 0xc015ed1760)
| pkg/kv/db.go:232 +0x1e2
| github.com/cockroachdb/cockroach/pkg/kv.SendWrappedWithAdmission({_, _}, {_, _}, {{0x0, 0x0}, 0x0, {0x0, 0x0}, {0x0, ...}, ...}, ...)
| pkg/kv/sender.go:498 +0x224
| github.com/cockroachdb/cockroach/pkg/kv.SendWrappedWith(...)
| pkg/kv/sender.go:483
| github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*ReplicaManifestCommitter).InstallNewManifest(0xc003fae008, 0x0, {{{0xc0020c2331, 0xf}, 0x42}, {0xc02390b6b0, 0x1, 0x1}}, {0x0, 0x0})
| pkg/kv/kvserver/replica_manifest_committer.go:258 +0xc57
| github.com/cockroachdb/cockroach/pkg/storage.(*TestingRSEngine).flushSSTables(0xc0192dac60, {0xc026d154b0, 0x1, 0xc000050808?}, 0x0)
| pkg/storage/rs_engine_testing.go:431 +0xf12
| github.com/cockroachdb/cockroach/pkg/storage.(*rsEngineContainer).FlushSSTables(0xc014befba0, {0xc026d154b0, 0x1, 0x1}, 0x0)
| pkg/storage/rs_engine_container.go:241 +0x115
| github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.installTestManifestForKey(0xc021c7a248, 0xc02316c008, {0xcef85d8, 0xc001bd9580}, {0xc035ca09d8, 0x1, 0x8})
| pkg/kv/kvserver/client_basalt_manifest_helpers_test.go:159 +0x844
| github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.TestGetSnapshotRSEngineSnapshot(0xc021c7a248)
| pkg/kv/kvserver/client_rsengine_test.go:86 +0x2b9
| testing.tRunner(0xc021c7a248, 0xcd8b600)
| GOROOT/src/testing/testing.go:2036 +0x21d
| created by testing.(*T).Run in goroutine 1
| GOROOT/src/testing/testing.go:2101 +0xb13
Error types: (1) *errbase.opaqueWrapper (2) *errutil.withPrefix (3) *errbase.opaqueWrapper (4) *errutil.leafError
Test: TestGetSnapshotRSEngineSnapshot
panic.go:694: -- test log scope end --
test logs left over in: outputs.zip/logTestGetSnapshotRSEngineSnapshot2457105002
--- FAIL: TestGetSnapshotRSEngineSnapshot (7.69s)
```

Parameters:
- attempt=1
- race=true
- run=1
- shard=38
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

/cc @cockroachlabs/kv-triage

[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestGetSnapshotRSEngineSnapshot.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)

Jira issue: CRDB-67204

Contributor guide

Open the contributing guide

Research direction

Start by running kv/kvserver.TestGetSnapshotRSEngineSnapshot with the reported race configuration and inspect the failure logs. Read pkg/kv/kvserver/client_rsengine_test.go, client_basalt_manifest_helpers_test.go, and pkg/storage/rs_engine_testing.go around the reported stack frames. Done means the test passes reliably under the reported basalt configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.