cockroachdb / cockroachdb/cockroach

storage/metamorphic: TestPebbleEquivalenceNightly failed

Open
#173,860 8 comments 0 reactions 0 assignees View on GitHub
A-storage branch-master C-test-failure O-robot T-storage
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

storage/metamorphic.TestPebbleEquivalenceNightly [failed](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_MiscNightlyTestsBazel/21481320?buildTab=log) with [artifacts](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_MiscNightlyTestsBazel/21481320?buildTab=artifacts#/) on master @ [889c09024fa5aea5b9c994899ac2fc0da6f3a62d](https://github.com/cockroachdb/cockroach/commits/889c09024fa5aea5b9c994899ac2fc0da6f3a62d):

```
github.com/cockroachdb/pebble.(*DB).makeRoomForWrite(0x5baa214a008, 0x5babb28a780)
external/com_github_cockroachdb_pebble/db.go:3115 +0x45
github.com/cockroachdb/pebble.(*DB).commitWrite.func1(0x5baa214a008, 0x5ba9e2601c8, 0x5babb28a780?, 0x5ba9e2601c0)
external/com_github_cockroachdb_pebble/db.go:1079 +0x96
github.com/cockroachdb/pebble.(*DB).commitWrite(0x5baa214a008, 0x5babb28a780, 0x5babb28a880, 0x5babb28a8d8)
external/com_github_cockroachdb_pebble/db.go:1081 +0x225
github.com/cockroachdb/pebble.(*commitPipeline).prepare(0x5baa6e48850, 0x5babb28a780, 0x0?, 0x69?)
external/com_github_cockroachdb_pebble/commit.go:495 +0x16a
github.com/cockroachdb/pebble.(*commitPipeline).Commit(0x5baa6e48850, 0x5babb28a780, 0x1, 0x0)
external/com_github_cockroachdb_pebble/commit.go:344 +0xc7
github.com/cockroachdb/pebble.(*DB).applyInternal(0x5baa214a008, 0x5babb28a780, 0x23?, 0x0)
external/com_github_cockroachdb_pebble/db.go:975 +0x20f
github.com/cockroachdb/pebble.(*DB).Apply(...)
external/com_github_cockroachdb_pebble/db.go:901
github.com/cockroachdb/pebble.(*DB).Set(0x5baa214a008, {0x5bab2e86330, 0x23, 0x23}, {0x5bab96d2ea0, 0x2e, 0x2e}, 0x38e6ca9)
external/com_github_cockroachdb_pebble/db.go:706 +0x9e
github.com/cockroachdb/cockroach/pkg/storage.(*Pebble).PutEngineKey(0x5baa0d1d888, {{0x5bab2e860c0, 0x10, 0x23}, {0x5bab2e860d0, 0x11, 0x13}}, {0x5bab96d2ea0, 0x2e, 0x2e})
pkg/storage/pebble.go:2014 +0xbe
github.com/cockroachdb/cockroach/pkg/storage.(*putBuffer).putLockMeta(0x5bab96e7680, {0x7448ec4389b8, 0x5baa0d1d888}, {0x5ba95ad35b0, 0xa, 0xa}, 0x4, 0x5bab96e76f0, 0x0)
pkg/storage/mvcc.go:1866 +0x1fa
github.com/cockroachdb/cockroach/pkg/storage.mvccPutInternal({_, _}, {_, _}, {_, _}, _, {0x5ba95ad35b0, 0xa, 0xa}, ...)
pkg/storage/mvcc.go:2760 +0x340a
github.com/cockroachdb/cockroach/pkg/storage.mvccPutUsingIter({_, _}, {_, _}, {_, _}, _, {0x5ba95ad35b0, 0xa, 0xa}, ...)
pkg/storage/mvcc.go:2064 +0x273
github.com/cockroachdb/cockroach/pkg/storage.MVCCPut({_, _}, {_, _}, {_, _, _}, {_, _}, {{0x5ba95ad35c0, ...}, ...}, ...)
pkg/storage/mvcc.go:1971 +0x567
github.com/cockroachdb/cockroach/pkg/storage/metamorphic.mvccPutOp.run({0x5ba9f3b2480, {0x5ba914dee40, 0x6}, {0x5ba95ad35b0, 0xa, 0xa}, {{0x5ba95ad35c0, 0xc, 0xc}, {0x0, ...}}, ...}, ...)
pkg/storage/metamorphic/operations.go:209 +0x170
github.com/cockroachdb/cockroach/pkg/storage/metamorphic.(*metaTestRunner).parseFileAndRun(0x5ba9f3b2480, {0x2402560, 0x5ba8ea0eca0?})
pkg/storage/metamorphic/generator.go:403 +0x9c7
github.com/cockroachdb/cockroach/pkg/storage/metamorphic.runMetaTestForEngines({{0x24255e0, 0x3b76340}, 0x5baa0596b48, 0x1, 0x6b42e7861f08c406, 0x0, {0x2402560, 0x5ba8ea0eca0}, {0x2402500, 0x5ba8ea0eca8}, ...})
pkg/storage/metamorphic/meta_test.go:90 +0x479
github.com/cockroachdb/cockroach/pkg/storage/metamorphic.runMetaTest.func2(0x5baa0596b48)
pkg/storage/metamorphic/meta_test.go:158 +0x5a7
testing.tRunner(0x5baa0596b48, 0x5baa08dfb80)
GOROOT/src/testing/testing.go:2036 +0xea
created by testing.(*T).Run in goroutine 12
GOROOT/src/testing/testing.go:2101 +0x4c5

goroutine 7674435 [select]:
github.com/cockroachdb/pebble.(*ConcurrencyLimitScheduler).granter(0x5baa1eeb040)
external/com_github_cockroachdb_pebble/compaction_scheduler.go:460 +0x9b
created by github.com/cockroachdb/pebble.(*ConcurrencyLimitScheduler).Register in goroutine 7674420
external/com_github_cockroachdb_pebble/compaction_scheduler.go:356 +0xf6

goroutine 10549267 [select, "output-level":"L0", "pebble":"flush"]:
github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFile).startTicker.func1()
external/com_github_cockroachdb_pebble/vfs/disk_health.go:259 +0xb5
created by github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFile).startTicker in goroutine 10546529
external/com_github_cockroachdb_pebble/vfs/disk_health.go:254 +0x58
```
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

/cc @cockroachlabs/storage

[Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)

Jira issue: CRDB-67156

Contributor guide

Open the contributing guide

Research direction

Start with the linked TeamCity build and artifacts, then read pkg/storage/metamorphic/meta_test.go, generator.go, operations.go, and the stack frames in pkg/storage/mvcc.go and pebble.go. Reproduce TestPebbleEquivalenceNightly and reduce the failure to its cause; done means the test passes reliably and the regression is covered or explained by the relevant test output.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.