cockroachdb / cockroachdb/cockroach

bulk: retry transient instance-lookup failures for execution locality across bulk jobs

Open
#173,621 1 comment 0 reactions 1 assignee Claimed by @andrew-r-thomas View on GitHub
A-disaster-recovery C-enhancement O-agent P-3 T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Summary:**
`MaybeRelocateJobExecution` marks a failure to resolve instances matching the
execution-locality filter with `ErrRelocateInstanceLookup` (transient — e.g.
nodes still starting) so each caller can set its own retry policy. Only CHANGEFEED
and now IMPORT mark it retryable (`jobs.MarkAsRetryJobError`); BACKUP/RESTORE do
not, so a transient lookup failure fails the job instead of retrying.

**Proposed work:**
- [ ] Apply `MarkAsRetryJobError` on `ErrRelocateInstanceLookup` to BACKUP/RESTORE.
- [x] Add test coverage for the retry branch (currently untested in IMPORT and
CHANGEFEED), likely via a testing knob on `MaybeRelocateJobExecution` that
forces the lookup error.

Epic CRDB-65504

Jira issue: CRDB-66932

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.